Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default stockpile limits to customparams #3959

Closed
sprunk opened this issue Nov 22, 2024 · 3 comments
Closed

Move default stockpile limits to customparams #3959

sprunk opened this issue Nov 22, 2024 · 3 comments
Labels
Good First Issue Good for newcomers Unit Def Issues with unit definition files

Comments

@sprunk
Copy link
Collaborator

sprunk commented Nov 22, 2024

Move values from this table to customparams, right now it's undiscoverable and can silently become obsolete if somebody uses a customparam anyway

local isStockpilingUnitNames = { -- number represents maximum stockpile. You can also use stockpileLimit customParam which overwrites whatever is set in this table
['armmercury'] = 5,
['corscreamer'] = 5,
['armthor'] = 2,
['legmos'] = 8,
['legmost3'] = 8,
['legmineb'] = 1,

@sprunk sprunk added the Good First Issue Good for newcomers label Nov 22, 2024
@SethDGamre SethDGamre added the Unit Def Issues with unit definition files label Nov 22, 2024
ryanbennitt pushed a commit to ryanbennitt/Beyond-All-Reason that referenced this issue Dec 4, 2024
@ryanbennitt
Copy link
Contributor

First pass at refactor, but couldn't find these units so haven't touched until confirmed they can be deleted:

	['armdecomlvl3'] = 1,
	['armdecomlvl6'] = 2,
	['armdecomlvl10'] = 2,
	['legdecomlvl3'] = 1,
	['legdecomlvl6'] = 2,
	['legdecomlvl10'] = 3, 

ryanbennitt pushed a commit to ryanbennitt/Beyond-All-Reason that referenced this issue Dec 4, 2024
@ryanbennitt
Copy link
Contributor

Aha found where they're stored, removed these too

ryanbennitt pushed a commit to ryanbennitt/Beyond-All-Reason that referenced this issue Dec 18, 2024
WatchTheFort pushed a commit that referenced this issue Dec 30, 2024
Refactor to move stockpile limits to the weapon defs instead of a list in gadget. Engine still only supports one stockpile weapon per unit, however.
@ryanbennitt
Copy link
Contributor

This issue can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Unit Def Issues with unit definition files
Projects
None yet
Development

No branches or pull requests

4 participants