Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't strip quoted comments #82

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

robtfm
Copy link
Collaborator

@robtfm robtfm commented Apr 9, 2024

fixes #81

ignore comment markers in " quotes (unless the quote is already in a comment).

also fix */ incorrectly stripping the marker and returning , and /* //* failing to recognise the second block start marker (thanks @stefnotch for the tests).

robtfm and others added 2 commits April 9, 2024 01:27
address partial token issues

Co-authored-by: stefnotch <[email protected]>
Copy link

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. I appreciate the new tests!

@robtfm robtfm merged commit 3e28f24 into bevyengine:master Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"//" in import declarations are incorrectly recognized as comments
3 participants