Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternative mechanism(s) to upgrade shillelagh #473

Open
turkoid opened this issue Sep 19, 2024 · 1 comment
Open

Use alternative mechanism(s) to upgrade shillelagh #473

turkoid opened this issue Sep 19, 2024 · 1 comment

Comments

@turkoid
Copy link

turkoid commented Sep 19, 2024

shillelagh.functions.upgrade uses pip to upgrade the module. This is a hidden dependency that is not automatically installed.

If using a different package manager such as uv I have to add pip as a requirement for my project, which doesn't seem right.

Either remove the upgrade function all together, or use a different mechanism to upgrade within the tool.

@betodealmeida
Copy link
Owner

Removing sounds a bit harsh, since it's a useful feature and pip is probably still the most popular way of installing Python packages.

Ideally we'd improve the function to check for pip/uv, and then have it do the right thing.

@betodealmeida betodealmeida removed the bug label Oct 30, 2024
@betodealmeida betodealmeida changed the title Remove or use different mechanism to upgrade shillelagh Use alternative mechanism(s) to upgrade shillelagh Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants