Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Config for JHEF435 new board #479

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Added Config for JHEF435 new board #479

merged 4 commits into from
Sep 26, 2024

Conversation

jhemcu
Copy link
Contributor

@jhemcu jhemcu commented Jun 25, 2024

This will be our first BF flight control hardware board for AT32F435.

@nerdCopter nerdCopter requested a review from a team June 25, 2024 15:00
haslinghuis
haslinghuis requested changes Jun 26, 2024
View reviewed changes
configs/JHEF435/config.h Outdated Show resolved Hide resolved
@jhemcu jhemcu force-pushed the JHEF435 branch 2 times, most recently from 0b178f0 to 16ff93b Compare July 7, 2024 01:51
haslinghuis
haslinghuis previously approved these changes Jul 7, 2024
View reviewed changes
@haslinghuis haslinghuis requested a review from ot0tot July 7, 2024 20:16
@ot0tot
Copy link
Contributor

ot0tot commented Jul 7, 2024

Have you joined the Discord and provided FC schematics?

Please join the Discord and message @sugaarK to arrange access to the manufacturer channel.

All targets must adhere to the updated Betaflight Manufacturer Guidelines: https://betaflight.com/docs/development/manufacturer/config-target-guidance

ot0tot
ot0tot reviewed Jul 7, 2024
View reviewed changes
configs/JHEF435/config.h Outdated Show resolved Hide resolved
ot0tot
ot0tot reviewed Jul 7, 2024
View reviewed changes
configs/JHEF435/config.h Outdated Show resolved Hide resolved
@haslinghuis haslinghuis dismissed their stale review July 8, 2024 13:32

Rerequest review after changes

@jhemcu
Copy link
Contributor Author

jhemcu commented Jul 9, 2024

Done~

@sugaarK
Copy link
Member

sugaarK commented Jul 9, 2024

Have you joined the Discord and provided FC schematics?

Please join the Discord and message @sugaarK to arrange access to the manufacturer channel.

All targets must adhere to the updated Betaflight Manufacturer Guidelines: https://betaflight.com/docs/development/manufacturer/config-target-guidance

@jhemcu you need to email me or talk to me on discord this process has changed as outlined here

https://betaflight.com/docs/development/manufacturer/config-target-guidance

ot0tot
ot0tot reviewed Sep 21, 2024
View reviewed changes
configs/JHEF435/config.h Outdated Show resolved Hide resolved
ot0tot
ot0tot reviewed Sep 21, 2024
View reviewed changes
configs/JHEF435/config.h Outdated Show resolved Hide resolved
ot0tot
ot0tot reviewed Sep 21, 2024
View reviewed changes
configs/JHEF435/config.h Outdated Show resolved Hide resolved
ot0tot
ot0tot reviewed Sep 21, 2024
View reviewed changes
configs/JHEF435/config.h Outdated Show resolved Hide resolved
@ot0tot
Copy link
Contributor

ot0tot commented Sep 26, 2024

Working properly now with betaflight/betaflight#13917
👌

@haslinghuis haslinghuis merged commit ff1f76f into betaflight:master Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugaarK sugaarK sugaarK left review comments

@ot0tot ot0tot ot0tot approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhemcu @ot0tot @sugaarK @haslinghuis