Create YYRC-EAGLEF722 #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdCopter
reviewed
Jun 17, 2024
|
@tianv2mu0897 , may need to provide schematics and samples to dev-team. may need to join Discord and contact @sugaarK for such. |
haslinghuis
requested changes
Jun 18, 2024
update config
|
hello:
I have updated it;
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年6月18日(星期二) 晚上11:31
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@haslinghuis requested changes on this pull request.
In configs/YYRC-EAGLEF722V0:
> +#define PINIO1_CONFIG 129 +#define PINIO2_CONFIG 129 +#define PINIO1_BOX 0 +#define PINIO2_BOX 40
No PINIO pins defined.
⬇️ Suggested change -#define PINIO1_CONFIG 129 -#define PINIO2_CONFIG 129 -#define PINIO1_BOX 0 -#define PINIO2_BOX 40
In configs/YYRC-EAGLEF722V0:
> +#define GYRO_1_CS_PIN PA0 +#define USB_DETECT_PIN PA10 +#define PULLDOWN_PIN_UART1 PC0 + +#define TIMER_PIN_MAPPING \ + TIMER_PIN_MAP( 0, PB9 , 2, -1) \ + TIMER_PIN_MAP( 1, PC8 , 2, 0) \ + TIMER_PIN_MAP( 2, PC9 , 2, 0) \ + TIMER_PIN_MAP( 3, PA8 , 1, 0) \ + TIMER_PIN_MAP( 4, PA9 , 1, 0) \ + TIMER_PIN_MAP( 6, PB3 , 1, 0) \ + +#define ADC1_DMA_OPT 0 + +#define MAG_I2C_INSTANCE (I2CDEV_1) +#define USE_BARO
Duplicate define
⬇️ Suggested change -#define USE_BARO
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
YES,Is OK.
…------------------ Original ------------------
From: Mark Haslinghuis ***@***.***>
Date: Wed,Jun 19,2024 1:05 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Mention ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@haslinghuis commented on this pull request.
In configs/YYRC-EAGLEF722V0:
> +#define GYRO_1_CS_PIN PA0 +#define USB_DETECT_PIN PA10 +#define PULLDOWN_PIN_UART1 PC0 + +#define TIMER_PIN_MAPPING \ + TIMER_PIN_MAP( 0, PB9 , 2, -1) \ + TIMER_PIN_MAP( 1, PC8 , 2, 0) \ + TIMER_PIN_MAP( 2, PC9 , 2, 0) \ + TIMER_PIN_MAP( 3, PA8 , 1, 0) \ + TIMER_PIN_MAP( 4, PA9 , 1, 0) \ + TIMER_PIN_MAP( 6, PB3 , 1, 0) \ + +#define ADC1_DMA_OPT 0 + +#define MAG_I2C_INSTANCE (I2CDEV_1) +#define USE_BARO
@tianv2mu0897 please correct.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
haslinghuis
reviewed
Jun 18, 2024
it update PC0
|
It is update
…------------------ Original ------------------
From: Mark Haslinghuis ***@***.***>
Date: Wed,Jun 19,2024 6:43 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Mention ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@haslinghuis commented on this pull request.
In configs/YYRC-EAGLEF722V0:
> +#define SPI2_SCK_PIN PB13 +#define SPI3_SCK_PIN PC10 +#define SPI1_SDI_PIN PA6 +#define SPI2_SDI_PIN PB14 +#define SPI3_SDI_PIN B4 +#define SPI1_SDO_PIN PA7 +#define SPI2_SDO_PIN PB15 +#define SPI3_SDO_PIN PB5 +#define ADC_VBAT_PIN PB0 +#define ADC_CURR_PIN PC3 +#define FLASH_CS_PIN PB12 +#define MAX7456_SPI_CS_PIN PA15 +#define GYRO_1_EXTI_PIN PC4 +#define GYRO_1_CS_PIN PA0 +#define USB_DETECT_PIN PA10 +#define PULLDOWN_PIN_UART1 PC0
Sorry found one more ;) This pin does not exist.
⬇️ Suggested change -#define PULLDOWN_PIN_UART1 PC0
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
OK,
正在使用发音
I will contact @sugaarK;thank you.
…------------------ Original ------------------
From: nerdCopter ***@***.***>
Date: Tue,Jun 18,2024 10:29 PM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Mention ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@tianv2mu0897 , may need to provide schematics and samples to dev-team. may need to join Discord and contact @sugaarK for such.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
haslinghuis
reviewed
Jun 19, 2024
haslinghuis
approved these changes
Jun 19, 2024
haslinghuis
reviewed
Jun 19, 2024
haslinghuis
reviewed
Jun 19, 2024
|
OK,I will update.Thank you.
…------------------ Original ------------------
From: Mark Haslinghuis ***@***.***>
Date: Thu,Jun 20,2024 5:09 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Mention ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@haslinghuis commented on this pull request.
In configs/YYRC-EAGLEF722:
> +#define GYRO_1_CS_PIN PA0 +#define USB_DETECT_PIN PA10 +#define PULLDOWN_PIN PC0 + +#define TIMER_PIN_MAPPING \ + TIMER_PIN_MAP( 0, PB9 , 2, -1) \ + TIMER_PIN_MAP( 1, PC8 , 2, 0) \ + TIMER_PIN_MAP( 2, PC9 , 2, 0) \ + TIMER_PIN_MAP( 3, PA8 , 1, 0) \ + TIMER_PIN_MAP( 4, PA9 , 1, 0) \ + TIMER_PIN_MAP( 6, PB3 , 1, 0) \ + +#define ADC1_DMA_OPT 0 + +#define MAG_I2C_INSTANCE (I2CDEV_1) +#define USE_BARO ⬇️ Suggested change -#define USE_BARO +#define BARO_I2C_INSTANCE (I2CDEV_1)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Have made the updates already |
|
OK,I will update it;
…------------------ Original ------------------
From: Mark Haslinghuis ***@***.***>
Date: Thu,Jun 20,2024 5:11 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Mention ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@haslinghuis commented on this pull request.
In configs/YYRC-EAGLEF722:
> +#define ADC_VBAT_PIN PB0 +#define ADC_CURR_PIN PC3 +#define FLASH_CS_PIN PB12 +#define MAX7456_SPI_CS_PIN PA15 +#define GYRO_1_EXTI_PIN PC4 +#define GYRO_1_CS_PIN PA0 +#define USB_DETECT_PIN PA10 +#define PULLDOWN_PIN PC0 + +#define TIMER_PIN_MAPPING \ + TIMER_PIN_MAP( 0, PB9 , 2, -1) \ + TIMER_PIN_MAP( 1, PC8 , 2, 0) \ + TIMER_PIN_MAP( 2, PC9 , 2, 0) \ + TIMER_PIN_MAP( 3, PA8 , 1, 0) \ + TIMER_PIN_MAP( 4, PA9 , 1, 0) \ + TIMER_PIN_MAP( 6, PB3 , 1, 0) \ ⬇️ Suggested change - TIMER_PIN_MAP( 6, PB3 , 1, 0) \ + TIMER_PIN_MAP( 6, PB3 , 1, 0)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
OK,I will update it；
…------------------ Original ------------------
From: Mark Haslinghuis ***@***.***>
Date: Thu,Jun 20,2024 5:12 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Mention ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@haslinghuis commented on this pull request.
In configs/YYRC-EAGLEF722:
> + ++#define PINIO2_CONFIG 129 ++#define PINIO1_BOX 0 ++#define PINIO2_BOX 40 ⬇️ Suggested change - -+#define PINIO2_CONFIG 129 -+#define PINIO1_BOX 0 -+#define PINIO2_BOX 40
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
haslinghuis
reviewed
Jun 19, 2024
|
It is be use
…------------------ Original ------------------
From: Mark Haslinghuis ***@***.***>
Date: Thu,Jun 20,2024 5:19 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Mention ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@haslinghuis commented on this pull request.
In configs/YYRC-EAGLEF722:
> +#define SPI2_SCK_PIN PB13 +#define SPI3_SCK_PIN PC10 +#define SPI1_SDI_PIN PA6 +#define SPI2_SDI_PIN PB14 +#define SPI3_SDI_PIN B4 +#define SPI1_SDO_PIN PA7 +#define SPI2_SDO_PIN PB15 +#define SPI3_SDO_PIN PB5 +#define ADC_VBAT_PIN PB0 +#define ADC_CURR_PIN PC3 +#define FLASH_CS_PIN PB12 +#define MAX7456_SPI_CS_PIN PA15 +#define GYRO_1_EXTI_PIN PC4 +#define GYRO_1_CS_PIN PA0 +#define USB_DETECT_PIN PA10 +#define PULLDOWN_PIN PC0 ⬇️ Suggested change -#define PULLDOWN_PIN PC0
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ot0tot
reviewed
Jun 19, 2024
|
OK,I will update it,Thank you!
…------------------ Original ------------------
From: ot0tot ***@***.***>
Date: Thu,Jun 20,2024 6:17 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Mention ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@ot0tot commented on this pull request.
Two minor changes suggested, otherwise it looks good!
In configs/YYRC-EAGLEF722:
> +#define USE_GYRO +#define USE_GYRO_SPI_MPU6000 +#define USE_GYRO_SPI_ICM42688P +#define USE_BARO +#define USE_BARO_BMP280 +#define USE_BARO_DPS310 +#define USE_FLASH +#define USE_FLASH_M25P16 +#define USE_MAX7456 + +#define BEEPER_PIN PC13 +#define MOTOR1_PIN PC9 +#define MOTOR2_PIN PC8 +#define MOTOR3_PIN PA8 +#define MOTOR4_PIN PA9 +#define RX_PPM_PIN PB9
Does this FC actually have a PPM input pin?
In configs/YYRC-EAGLEF722:
> +#define TIMER_PIN_MAPPING \ + TIMER_PIN_MAP( 0, PB9 , 2, -1) \ + TIMER_PIN_MAP( 1, PC8 , 2, 0) \ + TIMER_PIN_MAP( 2, PC9 , 2, 0) \ + TIMER_PIN_MAP( 3, PA8 , 1, 0) \ + TIMER_PIN_MAP( 4, PA9 , 1, 0) \ + TIMER_PIN_MAP( 6, PB3 , 1, 0) + +#define ADC1_DMA_OPT 0 + +#define MAG_I2C_INSTANCE (I2CDEV_1) +#define BARO_I2C_INSTANCE (I2CDEV_1) + +#define ADC_INSTANCE ADC1 +#define DEFAULT_BLACKBOX_DEVICE BLACKBOX_DEVICE_FLASH +#define DEFAULT_DSHOT_BURST DSHOT_DMAR_ON
No need to set DShot burst to On. Delete this or set to AUTO.
Consider adding #define DEFAULT_DSHOT_BITBANG DSHOT_BITBANG_ON.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
hello:
hello:
i am join in discord,how i will contact he? what is his discord name?can you tell me and his discord name;Thank you!
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年6月18日(星期二) 晚上10:29
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@tianv2mu0897 , may need to provide schematics and samples to dev-team. may need to join Discord and contact @sugaarK for such.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
PPM is delete, DShot burst set to AUTO,and adding #define DEFAULT_DSHOT_BITBANG DSHOT_BITBANG_ON.
|
hello:
betafligth/config is When can it be merged into BETAFLIGHT！thank you!
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年6月20日(星期四) 上午6:17
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
@ot0tot commented on this pull request.
Two minor changes suggested, otherwise it looks good!
In configs/YYRC-EAGLEF722:
> +#define USE_GYRO +#define USE_GYRO_SPI_MPU6000 +#define USE_GYRO_SPI_ICM42688P +#define USE_BARO +#define USE_BARO_BMP280 +#define USE_BARO_DPS310 +#define USE_FLASH +#define USE_FLASH_M25P16 +#define USE_MAX7456 + +#define BEEPER_PIN PC13 +#define MOTOR1_PIN PC9 +#define MOTOR2_PIN PC8 +#define MOTOR3_PIN PA8 +#define MOTOR4_PIN PA9 +#define RX_PPM_PIN PB9
Does this FC actually have a PPM input pin?
In configs/YYRC-EAGLEF722:
> +#define TIMER_PIN_MAPPING \ + TIMER_PIN_MAP( 0, PB9 , 2, -1) \ + TIMER_PIN_MAP( 1, PC8 , 2, 0) \ + TIMER_PIN_MAP( 2, PC9 , 2, 0) \ + TIMER_PIN_MAP( 3, PA8 , 1, 0) \ + TIMER_PIN_MAP( 4, PA9 , 1, 0) \ + TIMER_PIN_MAP( 6, PB3 , 1, 0) + +#define ADC1_DMA_OPT 0 + +#define MAG_I2C_INSTANCE (I2CDEV_1) +#define BARO_I2C_INSTANCE (I2CDEV_1) + +#define ADC_INSTANCE ADC1 +#define DEFAULT_BLACKBOX_DEVICE BLACKBOX_DEVICE_FLASH +#define DEFAULT_DSHOT_BURST DSHOT_DMAR_ON
No need to set DShot burst to On. Delete this or set to AUTO.
Consider adding #define DEFAULT_DSHOT_BITBANG DSHOT_BITBANG_ON.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Awaiting schematics and dev samples. Have you joined the Discord and contacted @sugaarK ? |
|
I have joined the discord,But I didn't get in touch ***@***.*** ?
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年6月28日(星期五) 上午9:20
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
Awaiting schematics and dev samples. Have you joined the Discord and contacted @sugaarK ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Add PINIO TO PC1
sugaarK
approved these changes
Jul 12, 2024
|
邮件已收到，谢谢！
|
haslinghuis
requested changes
Jul 12, 2024
@tianv2mu0897 , in your repo, (assuming linux) then commit/push |
|
83488d4 is still not proper, it should be |
|
hello:
How do I operate on the page?Thank you!
How do I operate on the page
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年7月12日(星期五) 晚上9:51
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
83488d4 is still not proper, it should be EAGLEF722/config.h
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
hello:
How do I operate on the page?Thank you!
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年7月12日(星期五) 晚上9:51
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
83488d4 is still not proper, it should be EAGLEF722/config.h
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
nerdCopter
force-pushed
the
YYRC-EAGLEF722
branch
from
83488d4 to
ad0f6cb
Compare
|
|
@haslinghuis , please repeat last suggestion from new file. TY |
|
Thank you very much;
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年7月12日(星期五) 晚上10:29
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF722 (PR #465)
not possible via web-interface.
i fixed and pushed
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
haslinghuis
requested changes
Jul 12, 2024
haslinghuis
approved these changes
Jul 12, 2024
nerdCopter
approved these changes
Jul 12, 2024
haslinghuis
reviewed
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I would like to create a branch and look forward to merging it; As I am creating it for the first time, if there are any issues, I am very much looking forward to you telling me the problem points; Thank you!