Create YYRC-EAGLEF405 #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
requested changes
Jun 16, 2024
|
No,it is not aSPEDIXF405 clone.because，The config pull request is change. Use it as a reference.
…------------------ Original ------------------
From: Mark Haslinghuis ***@***.***>
Date: Mon,Jun 17,2024 6:19 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Author ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF405 (PR #464)
@haslinghuis requested changes on this pull request.
In configs/YYRC-EAGLEF405V0:
> +#define BOARD_NAME SPEDIXF405 +#define MANUFACTURER_ID SPDX
this is not supposed to be here.
is this a SPEDIXF405 clone?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Thank you! you tell me the problem, I will modify it to meet the requirements.
…------------------ Original ------------------
From: Mark Haslinghuis ***@***.***>
Date: Mon,Jun 17,2024 6:19 AM
To: betaflight/config ***@***.***>
Cc: tianmu0897 ***@***.***>, Author ***@***.***>
Subject: Re: [betaflight/config] Create YYRC-EAGLEF405 (PR #464)
@haslinghuis requested changes on this pull request.
In configs/YYRC-EAGLEF405V0:
> +#define BOARD_NAME SPEDIXF405 +#define MANUFACTURER_ID SPDX
this is not supposed to be here.
is this a SPEDIXF405 clone?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
update board_name and ID
|
@tianv2mu0897 , may need to provide schematics and samples to dev-team. may need to join Discord and contact @sugaarK for such. |
|
hello:
Does it refer to photos of our product？
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年6月18日(星期二) 晚上10:29
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF405 (PR #464)
@tianv2mu0897 , may need to provide schematics and samples to dev-team. may need to join Discord and contact @sugaarK for such.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Add PINIO1 to PC1
Update branch name
sugaarK
approved these changes
Jul 12, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
then commit/push |
|
7e787f6 is still not proper, it should be |
nerdCopter
force-pushed
the
YYRC-EAGLEF405
branch
from
7e787f6 to
d29bf00
Compare
@haslinghuis , please repeat last suggestions from new file, TY. |
haslinghuis
requested changes
Jul 12, 2024
haslinghuis
approved these changes
Jul 12, 2024
nerdCopter
approved these changes
Jul 12, 2024
haslinghuis
reviewed
Jul 12, 2024
|
Thank you to everyone for their help to me;
【天v2幕】
***@***.***
…------------------ 原始邮件 ------------------
发件人: "betaflight/config" ***@***.***>;
发送时间: 2024年7月12日(星期五) 晚上10:53
***@***.***>;
***@***.******@***.***>;
主题: Re: [betaflight/config] Create YYRC-EAGLEF405 (PR #464)
Merged #464 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I would like to create a branch and look forward to merging it; As I am creating it for the first time, if there are any issues, I am very much looking forward to you telling me the problem points; Thank you!