Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandPal hotkey doesn't work if browser binds the hotkey and you are in an input/textarea.... (e.g. ctrl-k) #52

Open
rouilj opened this issue Oct 6, 2023 · 0 comments

Comments

@rouilj
Copy link
Contributor

rouilj commented Oct 6, 2023

Hi Ben:

When I first started using command-pal, I tried binding it to a key that was used to trigger a menu item in my
browser. It would only work some of the time and I didn't figure out what was going on.

I think the issue is that the hotkey defined for command-pal overrides the browser hotkey, but only when you are
not in a text input or textarea. I.E. the equivalent of hotkeysGlobal=True needs to be enabled for the hotkey.

I think defining the hotkeys.filter function defined by initShortCuts to return true if the key matches the
command-pal hotkey will do the trick. How to implement this, I am not sure. Ideally this should be settable from the
CommandPal({}) configuration object.

I haven't seen any activity from you in a while.
Hope your doing well.

-- rouilj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant