-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for older versions of IE #3
Comments
@catmanjan I'm taking the progressive enhancement approach here. I mostly use these events to add/remove styling classes to indicate a user has dragged over an element. It's nice UI polish, but it's not vital to drag and drop. You can still drop on a dropzone that doesn't change its appearance on dragover. I basically treat the events like I treat Do you have a use case where these events are vital in old IE? (Will reopen if so) |
What exactly is your reason for closing? My use case is adding a hover style when dragging/dropping a file onto an element. It doesn't work in IE, therefore it is vital? 😕 |
@catmanjan at this point it's an enhancement, I've never promised old IE support. Reopened & labeled as such 😃 Old IE doesn't support DOM event constructors, and I don't want to bloat the library with cross-browser event junk to support a use-case I haven't had a need for. There's a pull request in for a jQuery plugin version here that I haven't had a chance to play with yet: https://github.com/bensmithett/dragster/pull/2/files That feels like a much nicer way to handle IE support - can you try it out & see if it solves your problems as is? |
jQuery does help with IE support but that PR is buggy. I will maintain a seperate repo with a jquery.dragster project, for anyone else seeing this, it is also available on Nuget, making version control easier for your MVC folk. |
@catmanjan sweet, thanks! I'll chuck a link in the main readme |
@catmanjan any chance you can list off the bugs you found in the other jquery plugin PR? |
Was suffering the same problem as issue #5. Also does not pass in global jQuery namespace correctly, causing issues with other incorrect plugins. |
Following Pull Request is working with IE9, IE10, IE11 and Edge: |
Great idea, useless in production without IE support :(
The text was updated successfully, but these errors were encountered: