Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin doesn't remove note when criteria does not match anymore #14

Open
matclab opened this issue Nov 25, 2022 · 6 comments
Open

plugin doesn't remove note when criteria does not match anymore #14

matclab opened this issue Nov 25, 2022 · 6 comments

Comments

@matclab
Copy link

matclab commented Nov 25, 2022

My filter is assignee_username=matclab&state=opened, and when I unassigned a gitlab issue, the associated tasks remains in place.

As a side note, I see the following messages in the console when syncing gitlab issues:

Gitlab Issues: File already exists.
@benr77
Copy link
Owner

benr77 commented Nov 25, 2022

Please can you specify your operating system and the obsidian version and the plugin version. Thanks.

@benr77
Copy link
Owner

benr77 commented Nov 25, 2022

Also please can you give me the exact title of your Gitlab issue - it's possible any special characters in the title are causing problems.

@matclab
Copy link
Author

matclab commented Nov 27, 2022

I'm on Arch linux with obsidian 1.0.3 and plugin 0.1.8.

I remember two issues with the following titles (but since, I've erased the data directory and synced again) :

  • k8s: cex-selector fails: /home/blast is not group writable.
  • k8s: Add FR locales in generated docker.

I tried again by assigning the last one to me, and the unassigning it. The note rests in the gitlab issues directory.

@benr77
Copy link
Owner

benr77 commented Nov 27, 2022

Ok so we have : and / in the issue titles which may well be causing invalid filenames.

We rationalise the filenames from the issue titles already, but I'm guessing this is not working fully.

I should have some time tomorrow to look into this further.

@benr77
Copy link
Owner

benr77 commented Nov 28, 2022

I cannot reproduce this issue. Using your example issue titles, I can successfully create and remove notes in Obsidian by changing the issue on Gitlab. I also can't get it to show me the File already exists message during this process.

One point - the notes will only be removed the next time the plugin checks Gitlab, which is automatically 30 seconds after Obsidian starts, followed by every 15 minutes. So the note will only be deleted when the next 15 minute interval expires. I know this sounds obvious but thought I'd best mention it :)

@matclab
Copy link
Author

matclab commented Dec 7, 2022

Thank you very much for taking the time to investigate.
I'll try to find some time to debug the problem and keep you informed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants