Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text isn't properly formatted in certain situations #7

Open
reallyely opened this issue Nov 10, 2020 · 5 comments
Open

Text isn't properly formatted in certain situations #7

reallyely opened this issue Nov 10, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@reallyely
Copy link

Great theme! Thanks for your hard work.

Windows 10, Obsidian 0.9.11, Obsidianite (Dark and Light Mode)

Two Issues I've run into so far

image
When a link is also bold, the text clipping appears to be unset.

image
Italicized text is forced to Operator Mono, but should fall back to Rubik as it's the free and recommended default font on your readme.

@bennyxguo bennyxguo self-assigned this Nov 17, 2020
@bennyxguo bennyxguo added the bug Something isn't working label Nov 17, 2020
@bennyxguo
Copy link
Owner

bennyxguo commented Nov 17, 2020

@reallyely The first issue bold formatting with links, I am still trying to find a way to fix that one. So it will be fixed sooner or later. For now try to not use bold formatting for links yet.

For the second issue, I will fix that in 1.1.1, what you suggests makes perfect sense. Thanks for reporting!

@zcysxy
Copy link

zcysxy commented Aug 12, 2021

@bennyxguo I think I fixed this using :not() pseudo-class.

.cm-strong:not(.cm-hmd-barelink):not(.cm-hmd-internal-link):not(.cm-highlight),
strong {
  -webkit-background-clip: text;
  -webkit-text-fill-color: transparent;
  padding: 0 0.1rem;
  color: #7aa2f7;
  background-color: #7aa2f7;
  background-image: linear-gradient(62deg, #87c2fd 0%, #dcb9fc 100%) !important;
}

I just exclude [], wikilinks and highlight for now, maybe there are some other inline formats should be excluded.

@iacore
Copy link

iacore commented Oct 29, 2021

Still reproduced on Linux.

@empressabyss
Copy link

empressabyss commented Apr 10, 2024

I'm super new to CSS but believe I found a fix for bold link issues! The exact issue I had was that if links were also bold, their text would not be rendered until hovered over.

In .../vaultname/.obsidian/themes/Obsidianite/theme.css (for me, on Linux), find the following section (line 757), and comment out the color: and position: lines:

a,
.internal-link,
.cm-hmd-internal-link,
.cm-link {
  text-decoration: none !important;

  /* color: var(--text-normal); */ 
  /* position: relative; */

  z-index: 1;
}

Bold links now display bold text styling correctly and still have their thick underline that grows and shrinks, and the text colour becomes white when hovered over.

@iacore I'm running the native version of Obsidian on Garuda Linux, and this worked for me!

Hope this helps someone!! 💜

@iacore
Copy link

iacore commented Apr 11, 2024

@empressabyss you can send a PR with the changes if you want.

  • fork project
  • git clone [email protected]/yourname/xxx.git
  • git checkout -b patch-1
  • add changes
  • git add .; git commit; git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants