Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't yet managed to get things working with monocular cues over on PR #21 . I've been going through the Neuris and MonoSDF papers/repos (very similar approaches, just slight differences in implementation details/filtering) to see what may be going wrong. In the meantime, I wanted to contribute something so I'll opened this PR to add normal rendering to the NeUS system/model.
I did some timing and found that without normal rendering on the lego scene without a mask it took around 15 minutes
Doing the naive implementation
took around 18 minutes, and modifying the
rendering
function andrgb_alpha_fn
to generate the normal map took around 16 minutes. This version is much less clean, but I think it probably makes sense considering for longer renders there will be a large time savingsI tested this with the Lego scene and DTU 65 using colmap. Things didn't seem to work with colmap and I'm not fully sure why. Heres the gifs of the outputs from both
Feels like there's something wrong with the camera parameters after using colmap. Heres an example image from one of the validation runs
lmk your thoughts.