Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell renderer refactoring #77

Open
5 of 14 tasks
bennyboer opened this issue Jul 31, 2022 · 0 comments
Open
5 of 14 tasks

Cell renderer refactoring #77

bennyboer opened this issue Jul 31, 2022 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request high priority

Comments

@bennyboer
Copy link
Owner

bennyboer commented Jul 31, 2022

Most cell renderers, especially the newer ones like the Combobox cell renderer always have the same patterns.

  • Introduce AbstractCanvasCellRenderer class that already supports common actions
  • Every cell should have an additional options field that is currently in most cell renderer values included
  • Remove editable fields from cell renderer options
    • Instead: introduce cell renderers solely for editing like a TextEditorCellRenderer that will render a text field.
    • A global event listener is to be provided at the TableEngine options where you can defined what happens when a cell is double clicked for example
    • When a cell is double clicked the users of the library are able to exchange the cell renderer for example for a double-clicked text cell, to the text editor cell renderer and set the editor options to replace the editor again with the previous renderer when done
  • Update cell renderer documentation

Refactoring checklist

  • Button
  • Checkbox
  • Combobox
  • DOM
  • Row/column header
  • Image
  • Loading
  • Progress
  • Rating
  • Text

To-Do

  • Global event listeners to for example exchange cell renderer on double click
  • Refactoring text cell renderer to not include an editor - instead create another cell renderer that is to be used instead
  • Remove editable field from text cell renderer
  • Update cell renderer documentation
@bennyboer bennyboer added documentation Improvements or additions to documentation enhancement New feature or request high priority labels Jul 31, 2022
@bennyboer bennyboer self-assigned this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request high priority
Projects
None yet
Development

No branches or pull requests

1 participant