Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for withForm #48

Open
benlucchesi opened this issue Dec 2, 2014 · 5 comments
Open

support for withForm #48

benlucchesi opened this issue Dec 2, 2014 · 5 comments

Comments

@benlucchesi
Copy link
Owner

It looks like the object used to hold keys used by the withForm method isn't serializable and is getting dropped from the session object. either that or the object isn't getting written to/read from the session before or after the cookie session is loaded. need to investigate.

@exell-christopher
Copy link

We were testing out this plugin as a replacement for container based sessions, but ran into the same withForm issue. The form token appears to be added to the session after render is called as it's generated in the gsp. Because the gsp is rendered after grails has set the status on the request, there is no chance to capture further changes to the session, and write out the new cookies. I have a fix for this that I'll do a pull request for shortly.

@benlucchesi
Copy link
Owner Author

great. that will be much appreciated. looking forward to it.

@benlucchesi
Copy link
Owner Author

hey exell-christopher,

were you able to test your changes with the test-suite as described in the response to your pull request?

-ben

@exell-christopher
Copy link

I haven't had a chance to get back to this yet. Hoping to sometime this
week.

On Mon, Apr 13, 2015 at 10:32 AM, Ben Lucchesi [email protected]
wrote:

hey exell-christopher,

were you able to test your changes with the test-suite as described in the
response to your pull request?

-ben


Reply to this email directly or view it on GitHub
#48 (comment)
.

@double16
Copy link

Fixed in https://github.com/double16/grails-cookie-session/tree/release/4.0.0

dependencies {
compile 'org.grails.plugins:cookie-session:4.0.0.RC1'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants