Skip to content
This repository has been archived by the owner on Feb 1, 2018. It is now read-only.

Failed test causes remainder of tests to not run #60

Open
mikestew opened this issue Jan 9, 2014 · 1 comment
Open

Failed test causes remainder of tests to not run #60

mikestew opened this issue Jan 9, 2014 · 1 comment

Comments

@mikestew
Copy link

mikestew commented Jan 9, 2014

Steps to repro:

  1. Run bwoken with multiple .js test files. One of those test files must fail.
    Observed:
    When the failing test runs, the test run stops and the remainder of tests are not run.

When running multiple tests, if one test fails the test run stops. In practical terms, that means if one component turns buggy, tests for non-buggy components will never run (and we'll never know for sure that they're non-buggy).

It could be argued that it is preferred that as many tests are run as possible. One failing test should not stop the run. Log the failure and move on.

Perhaps it's just a difference in philosophy between me and the bwoken authors. For now I've modified script.rb so that the run method does not raise if a test fails.

@listrophy
Copy link
Contributor

Regarding your last paragraph, I would tend to agree: this isn't a bug in my eyes, but a feature request. This could get added later as a command-line flag, but I'm fairly certain it won't be the default behavior.

I'd be happy to accept a PR for this if someone writes it. Otherwise, it won't be at the top of my priority list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants