-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a --check flag for ci #243
Comments
As a walkaround, I'm running this in my CI to check if there are changed files after running barrelsby.
|
No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator |
Inspired by the integration-tests script I think that a simple implementation for it would be to:
@BitForger, @bencoveney does this sound like a bad idea? |
Sorry, as you can tell we've both been pretty busy with the personal lives. My idea for implementation would probably be to walk through and do everything up until the point of creating the file and just compare the contents of the existing file with the string we created in memory. If it matches we exit 0 and if not we exit 1 with the differences if that isn't too hard to do. |
No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator |
No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator |
Background
Barrelsby should be used solely while developing, thus compiled barrels should be present while creating PRs.
Proposal
To validate this process, add a
--check
flag that will not output to the filesystem. Instead, it will compare the desired outputs with the current file system and exit with a non-zero code if there is such a difference. Desirable with some details about which files weren't added during the development phase.The text was updated successfully, but these errors were encountered: