Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 12 #210

Open
BitForger opened this issue Jan 8, 2022 · 5 comments
Open

Drop support for Node 12 #210

BitForger opened this issue Jan 8, 2022 · 5 comments
Labels

Comments

@BitForger
Copy link
Collaborator

As noted in the node release schedule, It drops out of support at the end of April. This serves as a notice that support will also be dropped for node 12 at that time. Barrelsby may or may not continue to work on node 12 after that point in time.

@BitForger BitForger pinned this issue Jan 8, 2022
@bencoveney
Copy link
Owner

bencoveney commented Jan 10, 2022

👍

I think the main thing impacting the node version will be which version of ES syntax the TypeScript compiler generates. If we drop support for node v12, we could potentially update that: https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping.

That should also be fairly easy to revert in the event that anybody desperately needs to build it for an earlier version.

I guess node v17 can go in this list as well? https://github.com/bencoveney/barrelsby/blob/v2.3.2/.github/workflows/node.js.yml#L19

@github-actions
Copy link

No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator

@github-actions
Copy link

No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator

@bencoveney
Copy link
Owner

Aside: Could consider configuring this option for issues we would like to keep open: https://github.com/actions/stale#exempt-issue-labels

@bencoveney bencoveney reopened this Nov 28, 2022
@BitForger
Copy link
Collaborator Author

Good point... updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants