From 0dd0f86e2181d29ca6e67f6c11efe21013523d0b Mon Sep 17 00:00:00 2001 From: Tobias Pfeiffer Date: Wed, 5 Jun 2024 10:58:59 +0200 Subject: [PATCH] Upgrade credo so it works with 1.17 and run 1.17 for fancy things on CI --- .github/workflows/main.yml | 12 ++++++------ mix.exs | 2 +- mix.lock | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 259142f1..cb428f5f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -70,26 +70,26 @@ jobs: with: path: tools/plts key: erlef-${{ runner.os }}-dialyzer-${{ matrix.elixir_version }}-${{ matrix.otp_version }}-${{ hashFiles(format('{0}{1}', github.workspace, '/mix.lock')) }} - if: contains(matrix.elixir_version, '1.16') + if: contains(matrix.elixir_version, '1.17') - run: mix deps.get - run: MIX_ENV=test mix compile --warnings-as-errors - run: mix credo - if: contains(matrix.elixir_version, '1.16') + if: contains(matrix.elixir_version, '1.17') - name: Check if formatted - if: contains(matrix.elixir_version, '1.16') + if: contains(matrix.elixir_version, '1.17') run: mix format --check-formatted - name: Actual Tests # this will let warnings slip through but I don't wanna replicate all that magic # right now run: MIX_ENV=test mix coveralls.github || mix test --failed # Apparently the one with `!` can't go without the fancy expression syntax - if: ${{ !contains(matrix.elixir_version, '1.16') }} + if: ${{ !contains(matrix.elixir_version, '1.17') }} - name: Actual Tests WITH warnings as errors run: MIX_ENV=test mix coveralls.github --warnings-as-errors || mix test --failed - if: contains(matrix.elixir_version, '1.16') + if: contains(matrix.elixir_version, '1.17') - name: Dialyzer run: mix dialyzer --halt-exit-status - if: contains(matrix.elixir_version, '1.16') + if: contains(matrix.elixir_version, '1.17') macos: name: Test on MacOS diff --git a/mix.exs b/mix.exs index b207a232..3e2a7e40 100644 --- a/mix.exs +++ b/mix.exs @@ -46,7 +46,7 @@ defmodule Benchee.Mixfile do {:deep_merge, "~> 1.0"}, {:statistex, "~> 1.0"}, {:ex_guard, "~> 1.3", only: :dev}, - {:credo, "~> 1.7.2-rc.0", only: :dev, runtime: false}, + {:credo, "~> 1.7.7-rc.0", only: :dev, runtime: false}, {:ex_doc, ">= 0.0.0", only: :dev, runtime: false}, {:excoveralls, "~> 0.13", only: :test}, {:dialyxir, "~> 1.0", only: :dev, runtime: false}, diff --git a/mix.lock b/mix.lock index 0e0cacca..aaf5298c 100644 --- a/mix.lock +++ b/mix.lock @@ -1,6 +1,6 @@ %{ "bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"}, - "credo": {:hex, :credo, "1.7.6", "b8f14011a5443f2839b04def0b252300842ce7388f3af177157c86da18dfbeea", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "146f347fb9f8cbc5f7e39e3f22f70acbef51d441baa6d10169dd604bfbc55296"}, + "credo": {:hex, :credo, "1.7.7-rc.0", "a7fb63b6e30e523355fb545cb089c5cba550b6d92e1a70db131e01a5dbb77368", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "c977f50ada33d6b053122945a0e4e74280585f7f8ac617aca46c913e88cc4de0"}, "deep_merge": {:hex, :deep_merge, "1.0.0", "b4aa1a0d1acac393bdf38b2291af38cb1d4a52806cf7a4906f718e1feb5ee961", [:mix], [], "hexpm", "ce708e5f094b9cd4e8f2be4f00d2f4250c4095be93f8cd6d018c753894885430"}, "dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"}, "doctest_formatter": {:hex, :doctest_formatter, "0.3.0", "19da9fd0d9d1e895f86d7508f1962d8a16393277f73aba1066dddb3d2adcdfc8", [:mix], [], "hexpm", "485f4dab4fc65ecf18aa342d285b393db16814d828caa671c42f9f781b68cf5a"},