consistent data pattern across all the page components

[aquibbaig]

Based on our useFetch service, the data pattern needs to be consistent across all page components (this is definitely what we need for a more readable and efficient design), for example:

// top level
const {error, loading, data} = useFetch(url)

if (error) return <div className="errorStyles">{error.message}</div>

if (loading && !data) return <div className="loading"><Spinner /></div>

if (!data) return <div>No data for the request</div>

// finally, shows data if everything's alright
return <div>{data.data}</div>

[akshatgarg12]

Can i work on this issue?

[aquibbaig]

@akshatgarg12 Sure, let me know if you need any help :)

Referencing a dependency in this comment #24

[akshatgarg12]

@aquibbaig Shall i remove error as a prop from RouteList component, so that we can handle the error without passing it?

[aquibbaig]

yeah, I guess. Errors should be handled in a scope where data is being fetched

…

On Wed, Dec 8, 2021 at 6:05 PM Akshat Garg ***@***.***> wrote: @aquibbaig <https://github.com/aquibbaig> Shall i remove error as a prop from RouteList <https://github.com/bench-routes/dashboard/blob/6faa0e13f87d6faaecc75ae2a563f55ee4b778c4/src/components/RouteList/index.tsx#L26> component, so that we can handle the error without passing it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGI23GC4HBRFTAZPFVI7IGLUP5GIHANCNFSM5H74YWPA> .