Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified error handling in bench routes #19

Open
ruddi10 opened this issue Jul 17, 2021 · 1 comment
Open

Unified error handling in bench routes #19

ruddi10 opened this issue Jul 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ruddi10
Copy link
Contributor

ruddi10 commented Jul 17, 2021

Currently, when a user does something invalid, for, e.g. set the Step value in the time querier less than or equal to 0, although we have conditions to ensure that such invalid actions are not executed, it will be better if we can inform the user about this by some toast notification or something similar

Approach -
We can have a separate store for handling errors and whenever we catch an error and want to display it we can dispatch an action setting the text that need to be displayed in the error thus rendering some toast notification for the user to see.

@muskankhedia muskankhedia added the enhancement New feature or request label Jul 18, 2021
@aquibbaig aquibbaig changed the title Handle conditions when user perform some invalid action Unified error handling in bench routes Jul 27, 2021
@MohdImran001
Copy link
Contributor

@aquibbaig and @muskankhedia , I would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants