-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
animating right prop from negative to 0 not properly handle #131
Comments
Same problem animating from NEGATIVE on 'bottom'. |
In _function applyCSSTransition(e, property, duration, ... i changed: offsetPosition = value - cleanPropertyValue; To: if (property=='bottom' || property=='right')
offsetPosition = value;
else
offsetPosition = value - cleanPropertyValue; Horrible hack, untested, didn't investigate anything properly - just needed a solution. BEWARE! |
Thanks for posting that fix, hitchhiker. It makes the "right" property animate as expected. I've run into this problem on multiple projects now. Ben, would you please fix this? In case anyone would like to know, to apply hitchhiker's fix to the current minified version, you change |
thanks ! this works for "bottom" too ! |
if I try to animate
$('.mobile-menu').animate({
right: 0
},
when .mobile-menu has right -200px, the return value for the transition is 200 instead of 0, I track the issue to the private method _applyCSSTransition under
offsetPosition = value - cleanPropertyValue;
value = 0 and cleanPropertyValue = -200 so the offsetPosition give me 200
in needs something else to handle the values correctly thanks!
The text was updated successfully, but these errors were encountered: