Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement brilliant fan expansion called Starsmith: Expanded Oracles #756

Open
themaster567 opened this issue May 14, 2023 · 2 comments
Open

Comments

@themaster567
Copy link

https://www.drivethrurpg.com/product/417619/Starsmith-Expanded-Oracles

It's an amazing product that you can set any price including free for, so I think it may be safe to include. Maybe it could be an optional toggle if people don't want it by default.

Take a look at his other expansions for both systems too. They all look like they're worthy tbh. It seems like all of them are as a "pay-what-you-want" sort of deal.

@rsek
Copy link
Collaborator

rsek commented May 14, 2023

yeah, i hear eric does good work, and you're not the first to ask about it. you may want to talk to aledroid on the ironsworn discord, as iirc they've been doing some work on setting up Starsmith's tables for their own use. maybe they can hook you up?

but, IMO, the most practical way to do this would be a separate module. there's several reasons for that:

  • foundry-ironsworn already has 300+ tables in it, for crying out loud 😉 that data adds up, and many hosting setups can put some constraints on storage. anything of this magnitude really needs to be opt-in so that we're not consuming a bunch of space for content that may not even be desired, and that opt-in has to happen before the package is downloaded. in other words, it needs to be a separate package.
  • it'd 3rd party content. typically, FVTT system packages include "core"/"canonical" content, while expansions and supplements (3rd party or otherwise) are the purview of modules. i'm uneasy with creating a situation that could misrepresent its authorship. all unofficial system package development involves a certain amount of editorialization, but you gotta draw a line somewhere
    • real talk: once certain package management improvements from v11 arrive, i'm going to give serious thought to splitting out Ironsworn: Delve into its own module... and Delve actually is canonical!
  • modules can be system agnostic. so people playing with other systems but wanting to use Starsmith tables would be SOL if it were integrated into this system. one of FVTT's greatest strengths is modules, and philosophically i think it'd be better to lean into that
  • supporting a big 3rd party expansion is a not-insignificant scope increase, in large part because it'd probably mean maintaining another dataforged-comptatible dataset myself 😬 with sundered isles on the horizon and no shortage of additional features/improvements that i'd like to work on, it seems unlikely that i'll have any bandwidth devote to this in the foreseeable future

anyways, that's just my two cents. @ben may differ on this -- thoughts?

@themaster567
Copy link
Author

themaster567 commented May 14, 2023

This is all extremely well-written and goes far beyond the hopes I even had. I expected to just be rejected, so I had begun the slow process of doing everything myself by hand. If there's more people besides me working on this in any form, I am elated!

EDIT:
Stop the presses! The creator of Starsmith already did all the hard work (potentially) and made both his custom assets and custom tables available as JSON files for Obsidian.

https://github.com/ericbright2002/Forged_in_Obsidian/blob/main/Starsmith-Expanded-Oracles.json
https://github.com/ericbright2002/Forged_in_Obsidian/blob/main/StarsmithAssets.json
https://github.com/ericbright2002/Forged_in_Obsidian/blob/main/Ironsmith-Expanded-Oracles.JSON

How easy would it be to port these?

EDIT 2:
I have begun the process of manually porting all the Starsmith Assets by hand. It's not very difficult but it'll probably be about two hours of week at my current pace. I'll probably divide up the work into time chunk, but once it's all done I'll share it.

Eric reached out on the Discord and said later today he would conver the JSON files for the oracles to .csv format. I can then use an importer tool to convert these tables into something Foundry wants. Once that's all done, I'll share them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants