the leaderElected event seems to be triggered on each heartbeat by all followers

[bagrounds]

I put together a little demo here

If I add a console.log statement in the leaderElected event handler, all followers spam that log statement even if the leader has not changed.

Perhaps there should be an event for the heartbeat, and a different event for a successful leader election.

[ben-ng]

Urgh, this is definitely a bug. I think the bug is here. That emit should only happen if the term is greater than the current term, not greater than or equal to, which is what it currently is.

Wanna give fixing it a shot?

[bagrounds]

If I change that from >= to >, then

1. the spamming stops
2. but now followers don't seem to emit the leaderElected event at all (not even once)
3. and a bunch of tests break

test output:
change-gte-to-gt-test-output-1488771562.txt

I tried a few variations, but was unable to get the followers to emit leaderElected exactly once.

I also noticed that there are 2 other places in the code where leaderElected event can be emitted (line 429 and line 544 in addition to line 570 that you pointed out above).