-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The library should have at least one runtime dependency to be really helpful #59
Comments
This would be great. @ClausKlein would you be willing to contribute something like this? |
Sure, I would like to help. |
Thanks! Feel free to create a PR or throw some ideas here. Let me know if there's anything I can do to help. |
Do you know the WindowsToolchain? This builds quite faster and makes it even more easy to setup a |
Why does this project need a runtime dependency? I think I need to hear some more concrete situations where runtime dependencies are required or at least clearly superior to other options. Note that this project is intentionally not an educational project to teach CMake [1]. It is intended to assist a reasonably experienced C++ engineer to start developing a standard library proposal. I would expect the typical proposal would have a fairly modest dependency list, frequently an empty one, but maybe I am too optimistic. [1] Jason Turner's https://github.com/cpp-best-practices/cmake_template is more in line for those goals. |
This is a fair question. I would imagine something the linear algebra proposal would have a runtime dependency on blas. The, now defunct, 2d graphics proposal would have a runtime dependency on cairo IIRC. |
I was unfamiliar with that. Thanks for pointing it out! My understanding is that most professional Windows developers use Visual Studio, but I could be out-of-date. |
Yes and No, many developers I know use also This toolchain also supports clang-cl with |
I took a look at the ISO Cpp 2024 developer survey and this is the breakdown for primary IDE/Editor used: |
I created this thread to start a conversation on what our preset list should be. I think to support most Windows C++ developers, we need a Visual Studio preset which is tested as part of CI. That doesn't preclude using WindowsToolchain in addition in our CI matrix that surfaces windows issues on PRs more quickly. |
Sure, but this library doesn't need a runtime dependency. I would think less is more when it comes to getting started on a new library. Of course, I would support someone documenting the relevant steps to add a dynamic dependency. Or better yet, someone working on a proposal that benefits from a dynamic dependency. |
I forgot gtest is a test dependency. I actually don't really think we need package manager, besides Google Test, all current projects are dependency-free. |
To show all aspect of an library, the example template should:
ctest --test-and-build usage example. ;-) |
An STATIC, SHARED buildable library should be created, not only a simple header only (INTERFACE).
It should also export only it public interface!
See too https://crascit.com/2019/10/16/cppcon-2019-deep-cmake-for-library-authors/
The text was updated successfully, but these errors were encountered: