Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is misleading when user was invited already #16

Open
unRARed opened this issue Dec 28, 2016 · 2 comments
Open

Error is misleading when user was invited already #16

unRARed opened this issue Dec 28, 2016 · 2 comments

Comments

@unRARed
Copy link

unRARed commented Dec 28, 2016

It wasn't clear from the error on the form that I had already been previously invited to the Slack org. Appears to hit line 83 of invite.go.

Screenship:
error

@tantalic
Copy link
Member

@unRARed Thanks for posting an issue. I don't believe the client library we are currently (https://github.com/nlopes/slack) using exposes any machine-readable error code but will need to investigate this further. If this is the case there are two potential paths forward I see:

  1. Implement better error handling within nlopes/slack such that API errors can be inspected. Hopefully this would be accepted upstream so we would not need to maintain our own fork.
  2. Fetch the list of users and check for membership prior to submitting to the Slack API and check for membership.

My preference at this point would be #1, assuming it would be welcomed upstream.

@tantalic
Copy link
Member

It should also be noted that this affects the Mail Chimp signup as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants