Make Flake8 line limit consistent with Black and shorten lines to comply #2993
+645
−410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it consistent with the limit set in Black.
marcbradshaw
force-pushed
the
2975-flake8-line-limit
branch
2 times, most recently
from
341380c
to
6c58568
Compare
marcbradshaw
force-pushed
the
2975-flake8-line-limit
branch
from
341380c
to
ab46261
Compare
mhsmith
reviewed
Nov 25, 2024
core/src/toga/app.py
Outdated
| @@ -106,7 +106,7 @@ def __iter__(self) -> Iterator[Widget]: | |||
| return self.values() | |||
|
|
|||
| def __repr__(self) -> str: | |||
| return f"{{{', '.join(f'{k!r}: {v!r}' for k, v in sorted(self._registry.items()))}}}" | |||
| return f"{{{', '.join(f'{k!r}: {v!r}' for k, v in sorted(self._registry.items()))}}}" # noqa: E501 | |||
There was a problem hiding this comment.
This line can be split as shown in 7654820.
gtk/src/toga_gtk/container.py
Outdated
Comment on lines
159
to
161
| # print(self._content, f"Container layout " | ||
| # "{allocation.width}x{allocation.height} @ {allocation.x}x{allocation.y}") | ||
| # # noqa: E501 |
There was a problem hiding this comment.
Even though it's commented out, this line can still be split like any other string.
There was a problem hiding this comment.
ah, the noqa pragma was existing, and of course should have been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flake8 line limit is inconsistent with Black, this PR updates the config to be consistent, and shortens lines to comply with the new limit, as required.
Some lines with very long method names were skipped, ironically by making them even longer and adding a noqa comment
Fixes #2975
PR Checklist: