Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Enhancement ] The value for redis host is hardcoded. Can it be inferred from env variable or variable ? #15

Open
sid-dob opened this issue Jan 22, 2019 · 4 comments

Comments

@sid-dob
Copy link

sid-dob commented Jan 22, 2019

This creates an issue when we rename containers for staging purposes.

@beevelop
Copy link
Owner

Well, I guess you could inject the value for the redis host dynamically. PR welcomed.

@sid-dob
Copy link
Author

sid-dob commented Jan 30, 2019

Do environment variables work in uniqush-push.conf file ? I couldn't find that in the documentation.

Another thing that might be possible would be to use shell( sed and awk ) to replace host=redis with the other host. But this seems error-prone.

@beevelop
Copy link
Owner

We could add templating with ENV variables by customizing the entrypoint. I mostly use envsubst for this stuff.

@sid-dob
Copy link
Author

sid-dob commented Feb 1, 2019

Added PR #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants