Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable shift supervisor boolean field #398

Open
konykon opened this issue Jun 2, 2022 · 3 comments
Open

Editable shift supervisor boolean field #398

konykon opened this issue Jun 2, 2022 · 3 comments
Assignees

Comments

@konykon
Copy link

konykon commented Jun 2, 2022

Hello @victor-champonnois ,

I open this issue to ask if it would be possible to propose a change in shift management. It is regarding beesdoo_shift module and super field.

For now, in order to assign a supervisor to a shift, it is necessary to:

  • Define a worker partner as a supervisor in Contacts > Subscribe to shift.
  • Or go to the Shift template, find the Shift where you want to assign the supervisor and assign them.

1

We propose to make the field super editable in res_partner view where the Worker information. Is there a specific reason for which it is readonly?

2

Another suggestion is to add the super field to the wizard of assignment of the module beesdoo_shift_attendance.

3

I attach a couple of pictures to facilitate.

If you find these changes reasonable, let me know and I will open a pull request.

Thank you!

@victor-champonnois
Copy link
Member

Thank you for the issue @konykon
@remytms tagging you on this since you are the shift expert !

@remytms remytms self-assigned this Jun 7, 2022
@konykon
Copy link
Author

konykon commented Jul 6, 2022

Hello @remytms did you have time to take a look?
Thank you!

@vdewulf
Copy link

vdewulf commented Jul 7, 2022

Hello @konykon
@remytms is off until September, so I'll answer from a functional point of view.

  1. We propose to make the field super editable in res_partner view where the Worker information. Is there a specific reason for which it is readonly? ==> I don't remember any specific reason to make it read only but I might forget something about that. The idea of the flow is that you'll have a new cooperator and you want to assign him to a shift. You ask him if he wants to become supervisor and you can do it in one click in the subscribe to shift wizard. I think we need to keep this there.
    But we can decide to make it also editable on the res_partner as well.
    You can create a PR for that :)

  2. Another suggestion is to add the super field to the wizard of assignment of the module beesdoo_shift_attendance.
    ==> For that, I don't understand the user need about it. Can you explain?

Thanks and sorry for the delay from Coop IT Easy team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants