Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI elements overlap with system UI with Android 15's edge-to-edge enforcement #1549

Open
cillyvms opened this issue Nov 25, 2024 · 2 comments · May be fixed by #1550
Open

UI elements overlap with system UI with Android 15's edge-to-edge enforcement #1549

cillyvms opened this issue Nov 25, 2024 · 2 comments · May be fixed by #1550
Labels
bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@cillyvms
Copy link

Version

v3.3.1

Source

GitHub

Vault encryption

Yes (with biometric unlock)

Device

Pixel 8

Android version

Android 15

ROM

No response

Steps to reproduce

  1. Install Aegis on Android 15 or newer which enforces edge-to-edge
  2. Add enough entries to vault so they don't all fit on screen (if not using your real vault)
  3. Browse through different screens, potentially with 3-button navigation

What do you expect to happen?

Aegis adapts to the system UI by using WindowInsets

What happens instead?

Some UI elements are rendered behind system UI.

In the vault activity the "Showing n entries" text is partially behind the navigation hint.

Portrait Landscape
Screenshot_1 Screenshot_3

The same issue occurs in the settings activity (notice how the ripple animation is behind the navigation hint).

Portrait Landscape
Screenshot_2 Screenshot_4

The issue becomes worse if the user chose 3-button navigation instead of gesture navigation, as much more space is taken up by it.

Vault Settings
The "Showing n entries" text can be barely seen behind the navigation bar Screenshot_5 Screenshot_6

In landscape mode another issue occurs where the navigation bar obscures the overflow menu in the appbar.
Screenshot_7

This should hopefully be solved by consuming the WindowInsets provided by the system and adding margin/padding to the lists so they have enough extra space to scroll, so no UI element is stuck behind system UI. I'm not sure why the appbar doesn't adjust itself however.

I can open a PR for this adding the insets to the lists.

Log

No response

@cillyvms cillyvms added the bug A bug report label Nov 25, 2024
@michaelschattgen michaelschattgen added the bug-confirmed A confirmed and reproducible bug report label Nov 25, 2024
@michaelschattgen
Copy link
Member

Thanks for the detailed report, I noticed this myself too with the latest version on my phone. Feel free to take a shot at this if you'd like!

@cillyvms
Copy link
Author

Great! I'll look at adding the insets then.

@cillyvms cillyvms linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants