Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinearAxis cannot handle very small decimal numbers #77

Open
walterxie opened this issue Apr 7, 2017 · 2 comments
Open

LinearAxis cannot handle very small decimal numbers #77

walterxie opened this issue Apr 7, 2017 · 2 comments
Labels
enhancement
Milestone
v1.8

Comments

@walterxie
Copy link
Collaborator

walterxie commented Apr 7, 2017 •
edited
Loading

If value range is very small decimal numbers but the relative difference is huge, such as [1E-308, 1E-79], the int binCount = (int) ((axis.getMaxAxis() - axis.getMinAxis()) / binSize) + 2; will return negative value, and then while (binCount < minimumBinCount) will begin a dead loop.
@walterxie walterxie added the bug label Apr 7, 2017
@walterxie walterxie added this to the v1.6.2 milestone Apr 7, 2017
@walterxie
Copy link
Collaborator Author

walterxie commented Apr 7, 2017 •
edited
Loading

add majorTickCount < 1000 in HistogramPlot line 198, to avoid dead loop at the moment, but need better idea to handle small decimals in axis.

walterxie added a commit to beast-dev/beast-mcmc that referenced this issue Apr 7, 2017
@walterxie
temporary solution for beast-dev/tracer#77, need better idea
421642c
@walterxie walterxie modified the milestones: v1.6.2, v1.7 Jan 29, 2018
@walterxie walterxie added enhancement and removed bug labels Jan 31, 2018
@walterxie walterxie removed this from the v1.7 milestone Jan 31, 2018
@walterxie
Copy link
Collaborator Author

@rambaut
Not sure if log scale will solve the issue. Since the solution above stopped the error, I changed the issue label to enhancement.

@rambaut rambaut added this to the v1.7.1 milestone Apr 12, 2018
@rambaut rambaut modified the milestones: v1.7.1, v1.8 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.8
Development

No branches or pull requests
2 participants
@rambaut @walterxie