frontend: AutocompleteInput: escape * in fuzzyfinding (#1846) #1864
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inserting a suggestion, the value can have invalid characters, and in particular `*` which can easily be present on the payee: field or narration field. Fixes beancount#1846
yagebu
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Hi, thanks for the PR :)
Since this is not the only character that might cause issues when searching as a regular expression, would be good to solve that while we're at it. Could you create a function that covers all of them (and some tests)? (see e.g. this stackoverflow thread for possible solutions https://stackoverflow.com/questions/3561493/is-there-a-regexp-escape-function-in-javascript).
Edit: seems like we have that function already :) - escape in journal/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting a suggestion, the value can have invalid characters, and in particular
*which can easily be present on the payee: field or narration field.Fixes #1846