-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unrealized plugin only generates unrealized transactions after the current date (patch included) #6
Comments
Original comment by Jason Chu (Bitbucket: xentac, GitHub: xentac). I did realize that the text for the unrealized transactions should probably be updated to represent the relative change between the last unrealized transaction and the current one. Without that it feels a bit weird seeing "Unrealized loss ..." for 300 USD. |
Original comment by Martin Blais (Bitbucket: blais, GitHub: blais). Thanks Jason!
I do appreciate the patch, especially if it is backwards-compatible, though I'd like to eventually find a reporting-only solution to report returns over synthesizing realizations (but plugins are a great to experiment with alternatives in any case). |
Original comment by Jason Chu (Bitbucket: xentac, GitHub: xentac).
I'd like a reporting-only solution as well, but I'm having trouble picturing how that would actually work, apart from evaluating totals as market value instead of book value. |
CSV importer should report zero valued balances Approved-by: Martin Blais
Original report by Jason Chu (Bitbucket: xentac, GitHub: xentac).
This patch will generate an unrealized transaction for once per month, negating the previous month's transaction and adding the current month. This ends up recording monthly change as well as monthly unrealized value in a reasonable way.
I'm sure my style needs help (I know you have a code style, but I haven't been bothered to track down where you may have outlined it), but please tell me if this is way off base or not.
I also couldn't be bothered to make this a proper pull request, so take that for what you will.
The text was updated successfully, but these errors were encountered: