Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: when config value contains a colon the $config/dump returns invalid JSON #1270

Open
breiler opened this issue Jul 26, 2024 · 1 comment

Comments

@breiler
Copy link
Contributor

breiler commented Jul 26, 2024

Wiki Search Terms

N/A

Controller Board

N/A

Machine Description

N/A

Input Circuits

N/A

Configuration file

board: MKS TinyBee V1.0_001
name: CNC Router XYYZA 0-10V spindle and laser
meta: "(01.02.2022) by Skorpiboard: MKS TinyBee V1.0_001"

Startup Messages

Grbl 3.8 [FluidNC v3.8.0 (wifi) '$' for help]
$SS
[MSG:INFO: FluidNC v3.8.0 https://github.com/bdring/FluidNC]
[MSG:INFO: Compiled with ESP32 SDK:v4.4.7-dirty]
[MSG:INFO: Local filesystem type is littlefs]
[MSG:INFO: Configuration file:XYZAB_laser_24Jul24.yaml]
[MSG:INFO: Axes: using defaults]
[MSG:INFO: Machine CNC Router XYYZA 0-10V spindle and laser]
[MSG:INFO: Board MKS TinyBee V1.0_001]
[MSG:INFO: Stepping:RMT Pulse:4us Dsbl Delay:0us Dir Delay:0us Idle Delay:255ms]
[MSG:INFO: Axis count 3]
[MSG:INFO: Axis X (-1000.000,0.000)]
[MSG:INFO:   Motor0]
[MSG:INFO: Axis Y (-1000.000,0.000)]
[MSG:INFO:   Motor0]
[MSG:INFO: Axis Z (-1000.000,0.000)]
[MSG:INFO:   Motor0]
[MSG:INFO: Kinematic system: Cartesian]
[MSG:INFO: Using spindle NoSpindle]
[MSG:INFO: STA SSID is not set]
[MSG:INFO: AP SSID FluidNC IP 192.168.0.1 mask 255.255.255.0 channel 1]
[MSG:INFO: AP started]
[MSG:INFO: WiFi on]
[MSG:INFO: Captive Portal Started]
[MSG:INFO: HTTP started on port 80]
[MSG:INFO: Telnet started on port 23]
ok

User Interface Software

UGS and FluidNC Web Installer

What happened?

I got a report from a user where UGS failed to connect to a controller due to an invalid YAML configuration: winder/Universal-G-Code-Sender#2573

The proper way to include a colon (or other "special characters") in a YAML configuration value is to wrap the whole string with either " or '. The problem is that UGS uses the $Config/Dump which only prints the value without the string-wrap:

$Config/dump
board: MKS TinyBee V1.0_001
name: CNC Router XYYZA 0-10V spindle and laser
meta: (01.02.2022) by Skorpiboard: MKS TinyBee V1.0_001
...

GCode File

N/A

Other Information

No response

@breiler
Copy link
Contributor Author

breiler commented Sep 26, 2024

This was automatically closed when the PR in UGS was merged, opening this up again.

@breiler breiler reopened this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant