-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default server host should be localhost
#10
Comments
TODO follow-up, do we need to add https://github.com/handshake-org/hsd/blob/master/lib/node/http.js#L890-L895 |
This was referenced Jan 19, 2022
closing, see #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The main reason for this is to match the default in bcurl/client:
https://github.com/bcoin-org/bcurl/blob/d7e088fad4c284fb5d6fd7205c6b903bd3e6bf83/lib/client.js#L371
Right now bweb hosts explicitly on ipv4:
bweb/lib/server.js
Line 679 in 98327b4
and I believe this is causing issues on ipv6 enabled machines, such as handshake-org/hs-client#45
The text was updated successfully, but these errors were encountered: