From a8b77a1672f55a8f5cd4c5a8adc5f2ad67f435e3 Mon Sep 17 00:00:00 2001 From: manavdesai27 Date: Sun, 29 Jan 2023 11:55:31 +0530 Subject: [PATCH 1/3] Fix: Type mismatch --- lib/hd/hd.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/hd/hd.js b/lib/hd/hd.js index 58643f0ec..b6f310f2e 100644 --- a/lib/hd/hd.js +++ b/lib/hd/hd.js @@ -46,7 +46,7 @@ HD.generate = function generate() { /** * Generate an {@link HDPrivateKey} from a seed. - * @param {Object|Mnemonic|Buffer} options - seed, + * @param {Buffer} options - seed, * mnemonic, mnemonic options. * @returns {HDPrivateKey} */ @@ -57,7 +57,7 @@ HD.fromSeed = function fromSeed(options) { /** * Instantiate an hd private key from a mnemonic. - * @param {Mnemonic|Object} mnemonic + * @param {Mnemonic} mnemonic * @returns {HDPrivateKey} */ From a1eec353231fe12dd616fd9c3a79f81548747b72 Mon Sep 17 00:00:00 2001 From: Manav Desai Date: Thu, 11 May 2023 22:00:39 -0400 Subject: [PATCH 2/3] chore: changed options to seed --- lib/hd/hd.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/hd/hd.js b/lib/hd/hd.js index b6f310f2e..dfcfe874f 100644 --- a/lib/hd/hd.js +++ b/lib/hd/hd.js @@ -46,13 +46,12 @@ HD.generate = function generate() { /** * Generate an {@link HDPrivateKey} from a seed. - * @param {Buffer} options - seed, - * mnemonic, mnemonic options. + * @param {Buffer} seed - seed, * @returns {HDPrivateKey} */ -HD.fromSeed = function fromSeed(options) { - return HDPrivateKey.fromSeed(options); +HD.fromSeed = function fromSeed(seed) { + return HDPrivateKey.fromSeed(seed); }; /** From 3ab066c6547b6efae6678c077121ef96fb2641f3 Mon Sep 17 00:00:00 2001 From: Manav Desai Date: Fri, 12 May 2023 14:19:09 -0400 Subject: [PATCH 3/3] chore: change options to mnemonic --- lib/hd/hd.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/hd/hd.js b/lib/hd/hd.js index dfcfe874f..01cff9c10 100644 --- a/lib/hd/hd.js +++ b/lib/hd/hd.js @@ -56,12 +56,12 @@ HD.fromSeed = function fromSeed(seed) { /** * Instantiate an hd private key from a mnemonic. - * @param {Mnemonic} mnemonic + * @param {Mnemonic} mnemonic - mnemonic * @returns {HDPrivateKey} */ -HD.fromMnemonic = function fromMnemonic(options) { - return HDPrivateKey.fromMnemonic(options); +HD.fromMnemonic = function fromMnemonic(mnemonic) { + return HDPrivateKey.fromMnemonic(mnemonic); }; /**