Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][DEVSU-2089] SVG size in print #357

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Conversation

kttkjl
Copy link
Member

@kttkjl kttkjl commented Oct 6, 2023

  • New Inline-svg library
  • Auto portrait/landscape mode for svgs will need more work, turned off for now

Because rolling back to node 12 is waste of effort

@kttkjl kttkjl self-assigned this Oct 6, 2023
@kttkjl kttkjl requested a review from elewis2 October 6, 2023 10:24
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0c0ef68) 16.11% compared to head (448f8ad) 16.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   16.11%   16.11%           
=======================================
  Files         200      200           
  Lines        5814     5807    -7     
  Branches     1679     1675    -4     
=======================================
- Hits          937      936    -1     
+ Misses       4211     4205    -6     
  Partials      666      666           
Files Coverage Δ
app/components/SvgImage/index.tsx 71.69% <0.00%> (+6.69%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Unit Test Results

    1 files  ±0    28 suites  ±0   3m 21s ⏱️ +28s
145 tests  - 1  145 ✔️  - 1  0 💤 ±0  0 ❌ ±0 
142 runs   - 1  142 ✔️  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit 448f8ad. ± Comparison against base commit 0c0ef68.

@elewis2 elewis2 merged commit f23598c into master Oct 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants