Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/make preferred gene source configurable #114

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Dec 28, 2023

adds optional preferred-source arg to functions that call get_preferred_gene_name. This is because the value used is an rid which will be different in different instances of the db. To make this function usable with a non-bcgsc pori instance, the value needs to be settable.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2bc298) 90.35% compared to head (d520623) 90.35%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #114   +/-   ##
========================================
  Coverage    90.35%   90.35%           
========================================
  Files            8        8           
  Lines          840      840           
========================================
  Hits           759      759           
  Misses          81       81           
Flag Coverage Δ
unittests 90.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elewis2 elewis2 merged commit 15180c6 into develop Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants