Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFRS - Delete / remove icon for Schedule D fuel entry remains visible after submitting a compliance report #2339

Open
justin-lepitzki opened this issue May 26, 2023 · 1 comment
Labels
Bug Something isn't working Low Low priority Main release For immediate release into production when ready

Comments

@justin-lepitzki
Copy link
Collaborator

Describe the Bug
The delete/remove icon for a fuel entry in Schedule D remains visible in the UI after the compliance report has been submitted to government (i.e., when it does not have a Draft status).

Expected Behaviour
The delete/remove icon is not visible after the compliance report has been submitted to government (i.e., when the status is not Draft)

Actual Behaviour
The delete/remove icon is visible at all times regardless of report status

Implications
Gives the user the impression that entries can still be deleted after report submission

Steps To Reproduce
Steps to reproduce the behaviour:
User/Role: BCeID user with the Compliance Reporting role & all IDIR users

  1. Go to a Compliance Report that has a fuel entry within Schedule D and has been submitted to government (e.g., ID # 910 in Test env)
  2. Click on the Schedule D subtab
  3. See the delete/remove icon next to the fuel entry label

Screenshots:
Screenshot 2023-05-26 2.png

@justin-lepitzki justin-lepitzki added Bug Something isn't working Low Low priority labels May 26, 2023
@kcabhar
Copy link
Contributor

kcabhar commented May 26, 2023

@prv-proton prv-proton self-assigned this Jun 27, 2023
@justin-lepitzki justin-lepitzki added the Main release For immediate release into production when ready label Jun 30, 2023
@prv-proton prv-proton removed their assignment Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Low Low priority Main release For immediate release into production when ready
Projects
None yet
Development

No branches or pull requests

3 participants