Add number formatter to Nameplace Capacity

[dhaselhan]

No description provided.

[github-actions]

Backend Test Results

333 tests  ±0   128 ✅ ±0   45s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0   205 🔥 ±0 

For more details on these errors, see this check.

Results for commit 40413e0. ± Comparison against base commit a11dcc9.

♻️ This comment has been updated with latest results.

[github-actions]

Frontend Test Results

  1 files  ±0  114 suites  ±0   36s ⏱️ ±0s
367 tests ±0  347 ✅ ±0  20 💤 ±0  0 ❌ ±0 
369 runs  ±0  349 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 40413e0. ± Comparison against base commit a11dcc9.

♻️ This comment has been updated with latest results.

[prv-proton]

Hi @dhaselhan , thanks for the implementation, Please find my observations below.

• commas won't get added while editing, instead it gets formatted after editing is complete.

• Using NumberEditor component should fix this issue. Also if possible please fix the alignment to be same while editing and not editing.

[dhaselhan]

Hi @dhaselhan , thanks for the implementation, Please find my observations below.

• commas won't get added while editing, instead it gets formatted after editing is complete.

• Using NumberEditor component should fix this issue. Also if possible please fix the alignment to be same while editing and not editing.

Good catch Prashanth! Updated the code to use the NumberEditor and it works great. I did look at other places for column alignment and it looks like Fuel Quantity follows the same left/right behavior and I couldn't find any cells that work the way you are suggesting.

[prv-proton]

Hi @dhaselhan , thanks for the implementation, Please find my observations below.

• commas won't get added while editing, instead it gets formatted after editing is complete.

• Using NumberEditor component should fix this issue. Also if possible please fix the alignment to be same while editing and not editing.

Good catch Prashanth! Updated the code to use the NumberEditor and it works great. I did look at other places for column alignment and it looks like Fuel Quantity follows the same left/right behavior and I couldn't find any cells that work the way you are suggesting.

Thanks for the changes Daniel, I had a ticket similar to this changes in FuelCode carbonIntensity, and Al suggested this change. you can refer here
frontend/src/views/FuelCodes/AddFuelCode/_schema.jsx
type: 'leftAligned'. We can confirm this with Al and Stuart tomorrow if these needs to be consistent across.

Tested and looks good.