Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Automatic insertion based on index #54

Closed
mkoenig3 opened this issue Feb 8, 2024 · 2 comments
Closed

Feature request: Automatic insertion based on index #54

mkoenig3 opened this issue Feb 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mkoenig3
Copy link

mkoenig3 commented Feb 8, 2024

Hi Norman,

it would be great if there was a feature to make sure that newly appended data is inserted at the correct index location. For example, it would be cool if new data would be placed correctly along the 'time' dimension.

Thanks,
Marcel

@forman forman added the enhancement New feature or request label Feb 8, 2024
@forman
Copy link
Member

forman commented Feb 8, 2024

With the new append_step setting (#21) we could calculate the correct index location you are referring to and then update the location (#29) given that we have inserted empty dummy slices before appending a slice that is a multiple of append_step away from the last coordinate (another new feature).

If your feature request just concerns the order of slices that are appended in one invocation of zappend, then you could of course sort them on your own before passing the to zappend.

However, if data doesn't have a fixed append step size, but is strictly increasing or decreasing (#20) we could compute an insert location, but then all the subsequent steps would have to be shifted by the number of slices inserted. I feel, this is out-of-scope, as this would potentially require very large temporary storage for the rollback operation.

@mkoenig3
Copy link
Author

Thanks Norman, I agree! Sorting the slices should do for me, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants