Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: render: key is not a prop issue since 7.2.0-alpha.0 #23782

Closed
yannbf opened this issue Aug 10, 2023 · 21 comments · Fixed by #23792 or SimeonC/storybook-xstate-addon#58 · May be fixed by bbbtech/storybook-formik#72
Closed

[Bug]: render: key is not a prop issue since 7.2.0-alpha.0 #23782

yannbf opened this issue Aug 10, 2023 · 21 comments · Fixed by #23792 or SimeonC/storybook-xstate-addon#58 · May be fixed by bbbtech/storybook-formik#72
Assignees
@kasperpeulen
Labels
bug sev:S2 ui upgrade:7.2

Comments

@yannbf
Copy link
Member

yannbf commented Aug 10, 2023

Describe the bug

Since Storybook 7.2.0-alpha.0, any Storybook throws this error in the console:
image

After investigating, these are the candidate PRs introduced the issue:
UI: Improve Button layout and props - Chromatic
UI: Add storyStatus to sidebar UI - Chromatic
UI: Improve tabs component, more type correct, allow for FC as title - Chromatic

To Reproduce

Either of these options:

  1. Create a new Storybook project
  2. Update an existing Storybook project to 7.2.0-alpha.0 or higher
  3. Click on any of the Chromatic links I shared

Then check dev tools console

System

No response

Additional context

No response
@yannbf yannbf mentioned this issue Aug 10, 2023
Merged
5 tasks
@EugeneKamikaZe
Copy link

same issue on 7.2.2

@shilman shilman added the sev:S2 label Aug 10, 2023
@shilman shilman moved this to Empathy Backlog in Core Team Projects Aug 10, 2023
@pocka pocka mentioned this issue Aug 10, 2023
Closed
11 tasks
@kasperpeulen kasperpeulen mentioned this issue Aug 10, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Empathy Backlog to Done in Core Team Projects Aug 10, 2023
@kasperpeulen kasperpeulen reopened this Aug 10, 2023
@kasperpeulen
Copy link
Contributor

@EugeneKamikaZe Do you use addon-designs, and if so, could you see if upgrading to the latest version solved it?
https://www.npmjs.com/package/@storybook/addon-designs?activeTab=versions

@petegraves
Copy link

Upgrading to version 7.0.4 of @storybook/addon-designs fixed this error for me

@cdedreuille cdedreuille mentioned this issue Aug 11, 2023
Merged
5 tasks
@aldrichdev
Copy link

I was able to reproduce this when I upgraded the main Storybook package from 7.0.4 to 7.2.3, but once I upgraded the other @storybook/blah packages to the same version, I could not reproduce it.

@kasperpeulen
Copy link
Contributor

Thanks closing this for now. Please let us know if upgrading @storybook/addon-designs doesn't fix this for you!

@n19htz
Copy link

n19htz commented Aug 21, 2023 •
edited
Loading

I don't use @storybook/addon-designs and getting same error on the tab of "Tests" added by @storybook/addon-jest

Screen.Recording.2023-08-21.at.13.15.04.mov
Screenshot 2023-08-21 at 13 17 22

@n19htz n19htz mentioned this issue Aug 21, 2023
Closed
@jasosims jasosims mentioned this issue Aug 21, 2023
Closed
@Predhin
Copy link

Predhin commented Sep 4, 2023

same issue on v7.4.0 also

@EugeneKamikaZe
Copy link

same issue on 7.3.2

@likeuwill
Copy link

same issue on 7.4.1, i updated all libs to 7.4.1

@kasperpeulen
Copy link
Contributor

@Predhin @EugeneKamikaZe and @likeuwill
Can you please show the version of @storybook/addon-designs you are using?

@EugeneKamikaZe
Copy link

@kasperpeulen 7.0.5

@likeuwill
Copy link

likeuwill commented Sep 12, 2023 •
edited
Loading

@kasperpeulen i dont use addon-designs
main.ts

 addons: [
    '@storybook/addon-essentials',
    '@storybook/addon-themes',
    'storybook-addon-apollo-client'
  ]

and package.json

    "@storybook/addon-essentials": "7.4.1",
    "@storybook/addon-interactions": "7.4.1",
    "@storybook/addon-themes": "7.4.1",
    "@storybook/core-server": "7.4.1",
    "@storybook/nextjs": "7.4.1",
    "@storybook/test-runner": "^0.13.0",
    "@storybook/testing-library": "~0.2.0",

@kasperpeulen
Copy link
Contributor

kasperpeulen commented Sep 12, 2023 •
edited
Loading

@likeuwill I see that the bug is still there in storybook-addon-apollo-client indeed. I will raise a PR there.

kasperpeulen added a commit to kasperpeulen/storybook-addon-apollo-client that referenced this issue Sep 12, 2023
@kasperpeulen
Fix storybookjs/storybook#23782
7c36589
@kasperpeulen kasperpeulen mentioned this issue Sep 12, 2023
Closed
@kasperpeulen
Copy link
Contributor

@EugeneKamikaZe Can you show my your deps like @likeuwill did?

@EugeneKamikaZe
Copy link

@kasperpeulen

        '@storybook/addon-links',
        '@storybook/addon-essentials',
        '@storybook/addon-interactions',
        '@storybook/theming',
        {
            name: '@storybook/addon-coverage',
            options: {
                istanbul: {
                    ...coverageConfig,
                },
            },
        },
        '@storybook/addon-storysource',
        '@storybook/addon-a11y',
        '@whitespace/storybook-addon-html',
        '@bbbtech/storybook-formik/register',
        '@geometricpanda/storybook-addon-badges',
        '@storybook/addon-designs',
        'storybook-css-modules',
        'storybook-react-i18next',
        'storybook-addon-mock',
    ],

        "@geometricpanda/storybook-addon-badges": "^2.0.0",
        "@storybook/addon-a11y": "^7.3.2",
        "@storybook/addon-actions": "^7.3.2",
        "@storybook/addon-coverage": "^0.0.9",
        "@storybook/addon-designs": "^7.0.5",
        "@storybook/addon-essentials": "^7.3.2",
        "@storybook/addon-interactions": "^7.3.2",
        "@storybook/addon-links": "^7.3.2",
        "@storybook/addon-storyshots": "^7.3.2",
        "@storybook/addon-storyshots-puppeteer": "^7.3.2",
        "@storybook/addon-storysource": "^7.3.2",
        "@storybook/addon-styling": "^1.3.7",
        "@storybook/builder-vite": "^7.3.2",
        "@storybook/builder-webpack5": "^7.3.2",
        "@storybook/cli": "^7.3.2",
        "@storybook/jest": "^0.2.1",
        "@storybook/react": "^7.3.2",
        "@storybook/react-vite": "^7.3.2",
        "@storybook/test-runner": "^0.13.0",
        "@storybook/testing-library": "^0.2.0",
        "@storybook/theming": "^7.3.2",

@kasperpeulen
Copy link
Contributor

@bbbtech/storybook-formik/register has the issue indeed

kasperpeulen added a commit to kasperpeulen/storybook-formik that referenced this issue Sep 12, 2023
@kasperpeulen
Remove deprecated key
0fc0f9d 
Fixes storybookjs/storybook#23782
@kasperpeulen kasperpeulen mentioned this issue Sep 12, 2023
Open
@dawidjablonski89
Copy link

@tonai @kasperpeulen Hi, I believe I've found another addon that needs to be updated: storybook-addon-themes

https://github.com/tonai/storybook-addon-themes
https://storybook.js.org/addons/storybook-addon-themes

@yannbf
Copy link
Member Author

yannbf commented Sep 22, 2023 •
edited
Loading

@tonai @kasperpeulen Hi, I believe I've found another addon that needs to be updated: storybook-addon-themes

tonai/storybook-addon-themes storybook.js.org/addons/storybook-addon-themes

Thank you so much for that @dawidjablonski89 ! That addon is maintained by the community. It seems like it does not support Storybook 7 though: tonai/storybook-addon-themes#79

In that issue there's a new package which proposes an alternative that supports Storybook 7. Could you try that one out, and if it has the same issue, can you please open an issue on that repo?

@Predhin
Copy link

Predhin commented Sep 25, 2023

@kasperpeulen sorry for the delayed response,
"[@storybook/addon-designs]": "^7.0.5"

@atomicrobokid
Copy link

Same issue with @storybook/addon-storysource - v7.4.5

@yannbf
Copy link
Member Author

yannbf commented Oct 3, 2023

@Predhin and @atomicrobokid could you open issues respective to the packages which have them? Thanks!

@AvremelM AvremelM mentioned this issue Oct 25, 2023
Merged
@HighLiuk HighLiuk mentioned this issue Jan 11, 2024
Merged
@sookmax sookmax mentioned this issue May 8, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasperpeulen kasperpeulen

Labels
bug sev:S2 ui upgrade:7.2
Projects
Core Team Projects
Archived in project
Milestone
No milestone