Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External repository completions don't work with query sync #6843

Open
tpasternak opened this issue Oct 4, 2024 · 2 comments · May be fixed by #7031
Open

External repository completions don't work with query sync #6843

tpasternak opened this issue Oct 4, 2024 · 2 comments · May be fixed by #7031
Assignees
@tpasternak
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin topic: sync Issues related to the sync operation type: bug

Comments

@tpasternak
Copy link
Collaborator

tpasternak commented Oct 4, 2024 •
edited
Loading

Description of the bug:

It's because we don't call dump_repo_mapping in qsync mode.

cc @mtoader just to keep you in the loop, I think I will find some time to fix it next week
@tpasternak tpasternak added type: bug awaiting-maintainer Awaiting review from Bazel team on issues labels Oct 4, 2024
@mtoader
Copy link
Contributor

mtoader commented Oct 4, 2024

Yea :) i did ask if i should look into adding that in the original request.

@tpasternak
Copy link
Collaborator Author

Yeah, I thought the query sync was broken either way back then :D

@iancha1992 iancha1992 added the topic: sync Issues related to the sync operation label Oct 4, 2024
@iancha1992 iancha1992 added the product: IntelliJ IntelliJ plugin label Oct 4, 2024
@tpasternak tpasternak mentioned this issue Nov 5, 2024
Closed
tpasternak added a commit to tpasternak/bazel-intellij that referenced this issue Nov 21, 2024
@tpasternak
fix(qsync): External modules navigation in starlark files
6ba7c3b 
closes bazelbuild#6843
@tpasternak tpasternak linked a pull request Nov 21, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpasternak tpasternak

Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin topic: sync Issues related to the sync operation type: bug
Projects
Bazel IntelliJ Plugin
Status: Untriaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(qsync): External modules navigation in starlark files tpasternak/bazel-intellij
5 participants
@mtoader @tpasternak @sgowroji @iancha1992 @satyanandak