Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate native.existing_rule() and native.existing_rules() in non-finalizer context #23765

Open
tetromino opened this issue Sep 25, 2024 · 0 comments
Open

deprecate native.existing_rule() and native.existing_rules() in non-finalizer context #23765

tetromino opened this issue Sep 25, 2024 · 0 comments
Assignees
@tetromino
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols type: feature request

Comments

@tetromino
Copy link
Contributor

Once finalizers (#23160) and symbolic macros (#19922) are stable, we ought add an incompatible flag to allow native.existing_rule() and native.existing_rules() to be used only in finalizers (where their behavior is predictable), and enable that flag by default once the ecosystem has had time to adjust.

@brandjon fyi.
@tetromino tetromino added type: feature request P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols labels Sep 25, 2024
@tetromino tetromino self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetromino tetromino

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tetromino