-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps for go_proto_library
not generated when proto file name matches package name
#1926
Comments
davidbyttow
changed the title
Deps for generated
Deps for Sep 17, 2024
go_proto_library
missing when proto file name matches package namego_proto_library
not generated when proto file name matches package name
davidbyttow
added a commit
to davidbyttow/bazel-gazelle
that referenced
this issue
Sep 17, 2024
Well, I'm not sure if this is the appropriate fix, but seems to work. #1927 |
davidbyttow
added a commit
to davidbyttow/bazel-gazelle
that referenced
this issue
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of gazelle are you using?
0.38.0
What version of rules_go are you using?
0.50.1
What version of Bazel are you using?
7.3.1
Does this issue reproduce with the latest releases of all the above?
yes
What operating system and processor architecture are you using?
mac m2
Setup
file
modeproto/example/example.proto
(note the same name as the package) andproto/example/other.proto
One important note: and probably related, is that the target go_package does not match the proto package that is inferred. So it attempts to generate an empty package for the example go_proto_library, which seems to overwrite the rule generated before with the appropriate imports.
Here are the files:
example.proto
other.proto
Problem
After running Gazelle, the
example_go_proto
does not get its dependencies, unlikeother_go_proto
.What am I missing here? :)
The text was updated successfully, but these errors were encountered: