Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring registry_patterns in oci_pull #683

Open
sfc-gh-mhazy opened this issue Aug 27, 2024 · 2 comments
Open

Allow configuring registry_patterns in oci_pull #683

sfc-gh-mhazy opened this issue Aug 27, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sfc-gh-mhazy
Copy link
Contributor

Currently registry patterns are hardcoded here:

_WWW_AUTH = {

If one uses private registry, they can either add their pattern to this list (app.snowflake.com as an example), or apply patches in their workspaces.

I think the more flexible solution could be to allow passing the registry patterns in oci_pull.

I'm happy to add the change if you agree.

@shs96c
Copy link

shs96c commented Aug 27, 2024

Applying patches in a world where we rely on bzlmod isn't going to be appropriate or possible in all cases. Having a mechanism to add additional registry patterns that doesn't require us to patch rules_oci would be most useful.

@thesayyn
Copy link
Collaborator

I strongly agree with you both, there is #126.

I don't have the time to implement it myself, but if anybody is willing to put up a PR with some tests.

@thesayyn thesayyn added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants