-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed list of top-level package name is flawed for uncommon TLD's #280
Comments
So, the work-around is to specify
This is just missing from the documentation. |
Closing as it's just a duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/bazel-contrib/rules_jvm/blob/0bef82e8d7038a6628faad06b9a57d10e536c2c5/java/private/package.bzl#L2C1-L2C72
The implementation is fundamentally flawed.
For example, I've just spent a few hours trying to figure out why my test classes were not being properly named for their package (TLD of
kiwi
), in my specific case, tests insrc/test/java/kiwi/**/*
. All country-code TLD based packages would fail too.Bazel itself appears to use a heuristic based on the maven-style layout of a prefix of
src/test/java/
which is even noted in a comment!The simplest mitigation is probably to allow the prefix to be specified in the rule. E.g.
The text was updated successfully, but these errors were encountered: