-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare with rules_mypy #137
Comments
Honestly that one looks great. It fixes the mypy caching issue which is the biggest problem with this ruleset. |
Ok, I spent some time looking into it, and it's not a clear win. I have some local improvements that I've been meaning to get up here into this project. Let me try to find some time to do that. |
Great, thanks a bunch for trying that out and reporting what you found. @jbedard has been making changes in rules_ts to avoid that "run jobs down the dependency tree in serial" - but that's only recently possible because TypeScript introduced a way to create the equivalent of Without such a thing, I don't see how you could correctly type-check a library with no type information from its dependents, and would expect that serial chain. |
@alexeagle at one point I had a python tool that could spit out pyi files from the AST; it's actually not too bad because |
This module https://registry.bazel.build/modules/rules_mypy is new and claims to resolve some of the issues in this repo.
It also has enthusiastic maintainers and not so much legacy baggage.
@adzenith I think we should compare this repo with that one to decide if it's clearly a superset of what we are doing.
The text was updated successfully, but these errors were encountered: