Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unknown attributes only set on initial generated #1962

Open
jbedard opened this issue Oct 19, 2024 · 0 comments · May be fixed by #1952
Open

unknown attributes only set on initial generated #1962

jbedard opened this issue Oct 19, 2024 · 0 comments · May be fixed by #1952

Comments

@jbedard
Copy link
Contributor

jbedard commented Oct 19, 2024

If a language calls SetAttr for an attribute that is not in the KindInfo it is set on the initial rule generation but can never be updated.

What version of gazelle are you using?

0.38+

What version of Bazel are you using?

6.5, 7.0+

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

All

What did you do?

Invoke SetAttr in a language.

What did you expect to see?

The attribute should be updated.

What did you see instead?

The attribute is only set when the target is initially generated but never updated when the target already exists.
@jbedard jbedard linked a pull request Oct 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: overwrite attribute values when not mergeable jbedard/bazel-gazelle
1 participant
@jbedard