You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
does not work well with dependency injection. We got around this in data services with a custom Guice provider, but this should not be necessary. You should be able to create a Gumshoe instance, pass it around and have it work with thread local contexts and the like.
The Gumshoe class now has thread-local management at the static/class level. It should be pushed down to the instance level.
The context stack handling that happens at the instance level needs to be extracted to a new class that is managed by a Gumshoe instance.
The existing developer interface into gumshoe should be preserved. Gumshoe.get() should return a singleton Gumshoe instance.
Add docs for using Gumshoe with dependency injection
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current logic of accessing a Gumshoe instance
does not work well with dependency injection. We got around this in data services with a custom Guice provider, but this should not be necessary. You should be able to create a
Gumshoe
instance, pass it around and have it work with thread local contexts and the like.Gumshoe
instance.Gumshoe.get()
should return a singletonGumshoe
instance.The text was updated successfully, but these errors were encountered: