Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

Provide Gumshoe functionality through Gumshoe instance #24

Open
lwoodson opened this issue Aug 5, 2016 · 0 comments
Open

Provide Gumshoe functionality through Gumshoe instance #24

lwoodson opened this issue Aug 5, 2016 · 0 comments

Comments

@lwoodson
Copy link
Contributor

lwoodson commented Aug 5, 2016

The current logic of accessing a Gumshoe instance

Gumshoe.get()...

does not work well with dependency injection. We got around this in data services with a custom Guice provider, but this should not be necessary. You should be able to create a Gumshoe instance, pass it around and have it work with thread local contexts and the like.

  • The Gumshoe class now has thread-local management at the static/class level. It should be pushed down to the instance level.
  • The context stack handling that happens at the instance level needs to be extracted to a new class that is managed by a Gumshoe instance.
  • The existing developer interface into gumshoe should be preserved. Gumshoe.get() should return a singleton Gumshoe instance.
  • Add docs for using Gumshoe with dependency injection
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant