Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating submissions (and scrimmages?) breaks when not on team #13

Closed
n8kim1 opened this issue Oct 21, 2020 · 2 comments · Fixed by #209
Closed

Creating submissions (and scrimmages?) breaks when not on team #13

n8kim1 opened this issue Oct 21, 2020 · 2 comments · Fixed by #209
Labels
module: frontend Related to the Siarnaq frontend module priority: p1 critical type: bug Something isn't working

Comments

@n8kim1
Copy link
Contributor

n8kim1 commented Oct 21, 2020

from @wflms20110333 "If you try to submit code without officially creating and being on a team, it breaks. Should probably directly disallow submissions when not on teams (official one-man team is ok).

The funny thing is, the submissions tab is not displayed when you're not on a team, but I found the link in Getting Started anyway and unintentionally caught this."

A quick fix would be to say "make sure you're on a team!" on this site, but we should def look into a more robust solution later, for example by disabling the submission button entirely too. (Making the page completely inaccessible / redirecting instantly to the homepage seems unhelpful.)

Note -- this may also apply to trying to create a scrimmage when not on a team -- need to investigate.

see battlecode/battlehack20#100

n8kim1 referenced this issue in battlecode/battlecode21 Jan 7, 2021
Draft update to src for Issue #14
@LittleAlvinMaker
Copy link

I tested submitting a file without being on a team, and I got a "Forbidden" response. It seems that my fix is hidden behind a permissions check, which I suspect comes from the IsAuthenticatedOnTeam permission at views.py:671. Unfortunately, this means the upload fails without any visible feedback at all. Is that enough to close this issue, or is there more that needs to be done?

@n8kim1 n8kim1 transferred this issue from battlecode/battlecode21 Oct 30, 2021
@n8kim1 n8kim1 transferred this issue from another repository Aug 11, 2022
@n8kim1 n8kim1 changed the title Creating submissions (and scrimmages?) breaks when not on team [frontend] Creating submissions (and scrimmages?) breaks when not on team Aug 11, 2022
@n8kim1 n8kim1 added this to the Frontend - Scary bugs milestone Aug 12, 2022
@n8kim1
Copy link
Contributor Author

n8kim1 commented Aug 12, 2022

related: #6, #13, #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: frontend Related to the Siarnaq frontend module priority: p1 critical type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants