Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafe flag to the engine #116

Open
arvid220u opened this issue Apr 19, 2020 · 2 comments
Open

Add unsafe flag to the engine #116

arvid220u opened this issue Apr 19, 2020 · 2 comments
Labels
engine enhancement New feature or request

Comments

@arvid220u
Copy link
Contributor

In the unsafe mode, we would allow things like:

  1. pdb

and also remove the things that make code slower for the sake of security like:

  1. threads in threads (???? not sure if that's it honestly)
@arvid220u arvid220u added enhancement New feature or request engine labels Apr 19, 2020
@arvid220u arvid220u mentioned this issue Apr 19, 2020
@arvid220u
Copy link
Contributor Author

arvid220u commented Apr 19, 2020

See https://github.com/cooljoseph1/battlehack20-minimal, although we probably want to keep the bytecode limits and instrumentation in place because I think the threads are what's causing the big slowdown. I'm still not sure what the threads are used for

@arvid220u
Copy link
Contributor Author

We could also possibly make the debug flag mean exactly this and have the server run with --debug false. And then if we want the server to show debug outputs we can have another flag. Not sure what the best UI is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant